Add a dist-git-branch context #2935
Conversation
Signed-off-by: Cristian Le <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly adds the dist-git-branch context to Testing Farm jobs. However, I've identified a performance issue where fetching pull request details can result in redundant network requests. I've provided a suggestion to cache the pull request object, which will improve efficiency by ensuring the data is fetched only once per job run.
| # this has to be specified at the api request level. | ||
| # TODO: Revisit when 0.2 testing-farm API is decided | ||
| os_params = {"os": {"compose": compose}} if compose else {} | ||
| dist_git_branch = self.project.get_pr(self.metadata.pr_id).target_branch |
There was a problem hiding this comment.
This call to self.project.get_pr(self.metadata.pr_id) makes a network request. Since _get_tf_base_payload can be called multiple times within a single job run (e.g., for rpminspect and custom tests), this can lead to redundant API calls.
To improve efficiency, I suggest caching the pull request object on the helper instance. This ensures the PR is fetched only once per job run.
I've also noticed that _payload_custom makes a similar call. After applying this suggestion, you could refactor it to use the cached self._pr_object as well.
if not hasattr(self, "_pr_object"):
self._pr_object = self.project.get_pr(self.metadata.pr_id)
dist_git_branch = self._pr_object.target_branch
|
✔️ pre-commit SUCCESS in 1m 42s |
1 participant
Fixes #2924
RELEASE NOTES BEGIN
Testing farm jobs running against dist-git PRs now have the
dist-git-branchcontext pointing to the target branchof the PR.
RELEASE NOTES END